fix parsing of Authorization header #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Econe server fails with <NoMethodError: undefined method `split' for nil:NilClass> when using some clients (ec2 Ansible modules for example). The problem lies in parsing Authentication header format. Euca sends: Credential=tom/20160425/undefined-19606/ec2/aws4_request, SignedHeaders=accept;accept-encoding;connection;content-length;content-type;host;x-amz-content-sha256;x-amz-date, Signature=fsomehash8cda2 Ansible EC2 module sends: Credential=tom/20160425/servers/one/aws4_request,SignedHeaders=host;x-amz-date,Signature=6b2ccdsomehash39f2fc555 Previous implementation fails when fields are separated with "," (without space). Documentation [1] for AWS API says "are separated by a comma" so there should be just comma, but I'd prefer to maintain compatibility with euca and convert headers (remove spaces after comma). [1] http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-auth-using-authorization-header.html
rsmontero
pushed a commit
that referenced
this pull request
Jul 15, 2020
rsmontero
pushed a commit
that referenced
this pull request
Oct 6, 2020
(cherry picked from commit eac7e1e)
rsmontero
pushed a commit
that referenced
this pull request
Jan 20, 2021
rsmontero
pushed a commit
that referenced
this pull request
Apr 13, 2021
(cherry picked from commit eac7e1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Econe server fails with
when using some clients (ec2 Ansible modules for example). The problem
lies in parsing Authentication header format.
Euca sends:
Ansible EC2 module sends:
Previous implementation fails when fields are separated with "," (without space). Documentation [1] for AWS API says "are separated by a comma" so there should be just comma, but I'd prefer to maintain compatibility with euca and convert headers (remove spaces after comma).
[1] http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-auth-using-authorization-header.html